docs: log Phase 2 follow-up (worker logout + Account screen)

This commit is contained in:
Bas van Rossem
2026-06-17 18:24:07 +02:00
parent 1631c1698d
commit 7d7af335dd

View File

@@ -52,9 +52,25 @@ Implemented Phase 2 task-by-task per `docs/plans/phase-2-accounts-roles.md` (TDD
README (both dev logins; self-registration closed). Ran lint/format/typecheck and both test
suites green, plus the live HTTP smoke test proving the role rules.
## Follow-up (maintainer feedback, same day)
Two UX gaps surfaced once Phase 2 landed, both fixed in commit `1631c16`:
1. **No logout** — the worker client never surfaced `AuthContext.signOut`.
2. **Workers saw uneditable Settings** — the Instellingen tab *was* activity management, which
Phase 2 made admin-only, so every add/edit/delete 403'd for workers.
Decision (confirmed): the worker app stays worker-only. Replaced the Instellingen tab with an
**Account** screen (signed-in name/email via `/api/me` + an **Uitloggen** button), deleted the
activity-management `Settings` screen and its now-unused mutation hooks
(`useCreateActivity/useUpdateActivity/useDeleteActivity`; `useActivities` read stays for the
Stopwatch picker). Activity management belongs to the **Phase 3 admin app**. No backend change.
Worker: 22 tests + typecheck + `vite build` green.
## Plane
- Epic + tasks created under SoleLog (SL). See plan doc for the mapping.
- Follow-up item (logout + Account screen) created and marked Done.
## Next