test(admin): Auth (admin-only gate) — fill gaps + lifecycle test

apps/admin/src/auth/AuthContext.test.tsx

@@ -111,4 +111,15 @@ describe('AuthContext admin gate', () => {
     expect(window.location.pathname).toBe('/');
     expect(getToken()).toBeNull();
   });
+
+  it('useAuth throws when rendered outside an AuthProvider', () => {
+    function Orphan() {
+      useAuth();
+      return null;
+    }
+    // React logs the render error to console.error; silence it for the intentional throw.
+    const spy = vi.spyOn(console, 'error').mockImplementation(() => {});
+    expect(() => render(<Orphan />)).toThrow('useAuth must be used within an AuthProvider');
+    spy.mockRestore();
+  });
 });

apps/admin/src/screens/Login.test.tsx

@@ -0,0 +1,190 @@
+import { render, screen, waitFor, within } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
+import type { MeResponse } from '@solelog/shared';
+import Login from './Login';
+import App from '../App';
+import { AuthProvider } from '../auth/AuthContext';
+import { ApiError, signIn as apiSignIn } from '../lib/api';
+import { fetchMe } from '../api/me';
+import { clearToken, setToken } from '../lib/auth-storage';
+
+// Mock the network layer. signIn stores a token (mirror the real lib/api behaviour);
+// apiFetch is stubbed so the authed shell's list queries resolve cleanly in the lifecycle
+// test. fetchMe drives the admin-vs-worker gate. useMe stays real (runs on the mocked fetchMe).
+vi.mock('../lib/api', async () => {
+  const actual = await vi.importActual<typeof import('../lib/api')>('../lib/api');
+  return {
+    ...actual,
+    signIn: vi.fn(async () => {
+      setToken('tok');
+    }),
+    apiFetch: vi.fn().mockResolvedValue([]),
+  };
+});
+// fetchMe (used by the AuthContext gate) is the controllable mock. useMe (used by the shell's
+// Sidebar header) is stubbed to a no-data result — the gate, not the header, is under test here.
+vi.mock('../api/me', () => ({
+  fetchMe: vi.fn(),
+  useMe: () => ({ data: undefined }),
+}));
+
+const mockedSignIn = vi.mocked(apiSignIn);
+const mockedFetchMe = vi.mocked(fetchMe);
+
+const admin: MeResponse = {
+  user: { id: 'a1', email: 'admin@solelog.local', name: 'Admin', role: 'admin' },
+};
+const worker: MeResponse = {
+  user: { id: 'w1', email: 'worker@solelog.local', name: 'Werker', role: 'worker' },
+};
+
+function renderLogin() {
+  return render(
+    <AuthProvider>
+      <Login />
+    </AuthProvider>,
+  );
+}
+
+async function typeCredentials(user: ReturnType<typeof userEvent.setup>, email: string) {
+  await user.type(screen.getByLabelText('E-mailadres'), email);
+  await user.type(screen.getByLabelText('Wachtwoord'), 'pw');
+}
+
+describe('Login', () => {
+  beforeEach(() => {
+    mockedSignIn.mockReset();
+    mockedFetchMe.mockReset();
+    mockedSignIn.mockImplementation(async () => {
+      setToken('tok');
+    });
+  });
+
+  afterEach(() => {
+    clearToken();
+    vi.clearAllMocks();
+  });
+
+  it('submits the typed credentials to signIn', async () => {
+    mockedFetchMe.mockResolvedValue(admin);
+    const user = userEvent.setup();
+    renderLogin();
+
+    await typeCredentials(user, 'admin@solelog.local');
+    await user.click(screen.getByRole('button', { name: 'Inloggen' }));
+
+    await waitFor(() => expect(mockedSignIn).toHaveBeenCalledWith('admin@solelog.local', 'pw'));
+    // A successful admin sign-in surfaces no error.
+    expect(screen.queryByText('Inloggen mislukt')).not.toBeInTheDocument();
+  });
+
+  it('shows the admin-only message when a worker signs in (NotAdminError)', async () => {
+    mockedFetchMe.mockResolvedValue(worker);
+    const user = userEvent.setup();
+    renderLogin();
+
+    await typeCredentials(user, 'worker@solelog.local');
+    await user.click(screen.getByRole('button', { name: 'Inloggen' }));
+
+    await waitFor(() =>
+      expect(screen.getByText('Geen toegang — alleen beheerders.')).toBeInTheDocument(),
+    );
+  });
+
+  it('shows a generic error when the credentials are rejected', async () => {
+    mockedSignIn.mockRejectedValue(new ApiError(401, 'Inloggen mislukt'));
+    const user = userEvent.setup();
+    renderLogin();
+
+    await typeCredentials(user, 'admin@solelog.local');
+    await user.click(screen.getByRole('button', { name: 'Inloggen' }));
+
+    await waitFor(() => expect(screen.getByText('Inloggen mislukt')).toBeInTheDocument());
+  });
+
+  it('disables the submit button while the sign-in is pending', async () => {
+    let release!: () => void;
+    mockedSignIn.mockImplementation(
+      () =>
+        new Promise<void>((resolve) => {
+          release = () => {
+            setToken('tok');
+            resolve();
+          };
+        }),
+    );
+    mockedFetchMe.mockResolvedValue(admin);
+    const user = userEvent.setup();
+    renderLogin();
+
+    await typeCredentials(user, 'admin@solelog.local');
+    const button = screen.getByRole('button', { name: 'Inloggen' });
+    await user.click(button);
+
+    expect(button).toBeDisabled();
+    release();
+    await waitFor(() => expect(button).not.toBeDisabled());
+  });
+
+  it('clears a previous error on the next submit', async () => {
+    mockedSignIn.mockRejectedValueOnce(new ApiError(401, 'Inloggen mislukt'));
+    mockedFetchMe.mockResolvedValue(admin);
+    const user = userEvent.setup();
+    renderLogin();
+
+    await typeCredentials(user, 'admin@solelog.local');
+    const button = screen.getByRole('button', { name: 'Inloggen' });
+    await user.click(button);
+    await waitFor(() => expect(screen.getByText('Inloggen mislukt')).toBeInTheDocument());
+
+    // Second submit succeeds; the stale error is cleared.
+    await user.click(button);
+    await waitFor(() => expect(screen.queryByText('Inloggen mislukt')).not.toBeInTheDocument());
+  });
+});
+
+// Lifecycle (B-D1): worker credentials are rejected with the not-authorized message;
+// admin credentials render the authed shell.
+describe('admin-only gate lifecycle', () => {
+  beforeEach(() => {
+    mockedSignIn.mockReset();
+    mockedFetchMe.mockReset();
+    mockedSignIn.mockImplementation(async () => {
+      setToken('tok');
+    });
+  });
+
+  afterEach(() => {
+    clearToken();
+    vi.clearAllMocks();
+  });
+
+  it('rejects a worker with the not-authorized message, then admits an admin to the shell', async () => {
+    // First sign-in resolves a worker (rejected); the retry resolves an admin (admitted).
+    mockedFetchMe.mockResolvedValueOnce(worker).mockResolvedValue(admin);
+    const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
+    const user = userEvent.setup();
+    render(
+      <QueryClientProvider client={queryClient}>
+        <App />
+      </QueryClientProvider>,
+    );
+
+    // Login is shown; a worker attempt is rejected and the shell never renders.
+    await typeCredentials(user, 'worker@solelog.local');
+    await user.click(screen.getByRole('button', { name: 'Inloggen' }));
+    await waitFor(() =>
+      expect(screen.getByText('Geen toegang — alleen beheerders.')).toBeInTheDocument(),
+    );
+    expect(screen.queryByRole('navigation')).not.toBeInTheDocument();
+
+    // An admin attempt flips the gate and renders the authed shell (Sidebar nav).
+    await user.clear(screen.getByLabelText('E-mailadres'));
+    await typeCredentials(user, 'admin@solelog.local');
+    await user.click(screen.getByRole('button', { name: 'Inloggen' }));
+    await waitFor(() => expect(screen.getByRole('navigation')).toBeInTheDocument());
+    expect(within(screen.getByRole('navigation')).getByText('Live')).toBeInTheDocument();
+  });
+});